Skip to content

feat(v8/remix): Remove remixRouterInstrumentation #10933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 7, 2024
Merged

feat(v8/remix): Remove remixRouterInstrumentation #10933

merged 3 commits into from
Mar 7, 2024

Conversation

AbhiPrasad
Copy link
Member

ref #10898

@AbhiPrasad AbhiPrasad requested a review from a team March 5, 2024 16:12
@AbhiPrasad AbhiPrasad self-assigned this Mar 5, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and lforst and removed request for a team March 5, 2024 16:12
@AbhiPrasad AbhiPrasad mentioned this pull request Mar 5, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.5 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.75 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.65 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.3 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.98 KB (-0.18% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.98 KB (-0.18% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.36 KB (-0.01% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.36 KB (-0.02% 🔽)
@sentry/browser - Webpack (gzipped) 22.56 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - CDN Bundle (gzipped) 75.59 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (gzipped) 67.19 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - CDN Bundle (gzipped) 33.05 KB (-0.1% 🔽)
@sentry/browser - CDN Bundle (gzipped) 24.01 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (minified & uncompressed) 210.89 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing) - CDN Bundle (minified & uncompressed) 99.69 KB (-0.13% 🔽)
@sentry/browser - CDN Bundle (minified & uncompressed) 71.74 KB (-0.02% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.99 KB (-0.08% 🔽)
@sentry/react - Webpack (gzipped) 22.6 KB (-0.02% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.47 KB (-0.02% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 49.87 KB (-0.07% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.41 KB (-0.02% 🔽)

mydea
mydea reviewed Mar 6, 2024
View reviewed changes
packages/remix/src/client/performance.tsx
startTransactionOnPageLoad = true,
startTransactionOnLocationChange = true,
): void => {
setGlobals({
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can also remove the setGlobals method and everything related to it then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setGlobals is still used by browserTracingIntegration

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh right, sorry.

@AbhiPrasad AbhiPrasad force-pushed the abhi-remixRouterInstrumentation branch from a57f00e to 1574c2c Compare March 6, 2024 18:10
@AbhiPrasad AbhiPrasad merged commit 8dfa7c2 into develop Mar 7, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-remixRouterInstrumentation branch March 7, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@lforst lforst Awaiting requested review from lforst lforst was automatically assigned from getsentry/team-web-sdk-frontend

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @mydea